Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the build image #456

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Validate the build image #456

merged 1 commit into from
Sep 12, 2023

Conversation

djmb
Copy link
Collaborator

@djmb djmb commented Sep 12, 2023

Kamal needs images to have the service label so it can track them for pruning. Images built by Kamal will have the label, but externally built ones may not.

Without it images will build up over time. The worst case is an outage if all the hosts disks fill up at the same time.

We'll add a check for the label and halt if it is not there.

Fixes #403

Kamal needs images to have the service label so it can track them for
pruning. Images built by Kamal will have the label, but externally built
ones may not.

Without it images will build up over time. The worst case is an outage
if all the hosts disks fill up at the same time.

We'll add a check for the label and halt if it is not there.
@djmb djmb merged commit 9d49b3e into main Sep 12, 2023
6 checks passed
@djmb djmb deleted the validate-image branch September 12, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mrsk deployments filling up disk without cleaning overlay2 directory
1 participant